Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory action #641

Merged
merged 3 commits into from
May 14, 2024
Merged

Add inventory action #641

merged 3 commits into from
May 14, 2024

Conversation

ceelias
Copy link
Collaborator

@ceelias ceelias commented May 14, 2024

No description provided.

Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -e SC1004' returned error 1 finding the following syntactical issues:

----------

In .github/workflows/build-artifact/generate_inventory.sh line 12:
CHECK_HELM=false
^--------^ SC2034 (warning): CHECK_HELM appears unused. Verify use (or export if used externally).


In .github/workflows/build-artifact/generate_inventory.sh line 13:
CHECK_KUBERNETES=false
^--------------^ SC2034 (warning): CHECK_KUBERNETES appears unused. Verify use (or export if used externally).


In .github/workflows/build-artifact/generate_inventory.sh line 15:
source bin/common.sh
       ^-----------^ SC1091 (info): Not following: bin/common.sh was not specified as input (see shellcheck -x).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- CHECK_HELM appears unused. Verify...
  https://www.shellcheck.net/wiki/SC1091 -- Not following: bin/common.sh was ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt -s' returned error 1 finding the following formatting issues:

----------
--- .github/workflows/build-artifact/generate_inventory.sh.orig
+++ .github/workflows/build-artifact/generate_inventory.sh
@@ -21,18 +21,18 @@
 
 function buildHelmArchiveFilename {
 
-   local prefix repo name version format chart_archive_filename
+	local prefix repo name version format chart_archive_filename
 
-   prefix=$1
-   repo="${prefix}_CHART_REPO"
-   name="${prefix}_CHART_NAME"
-   version="${prefix}_CHART_VERSION"
-   format="tgz"
-   chart_archive_filename="${!repo}\/${!name}-${!version}.$format"
-   v4m_replace "__${prefix}_CHART_REPO__" "${!repo}" "$file"
-   v4m_replace "__${prefix}_CHART_NAME__" "${!name}" "$file"
-   v4m_replace "__${prefix}_CHART_VERSION__" "${!version}" "$file"
-   v4m_replace "__${prefix}_CHART_ARCHIVE__" "$chart_archive_filename" "$file"
+	prefix=$1
+	repo="${prefix}_CHART_REPO"
+	name="${prefix}_CHART_NAME"
+	version="${prefix}_CHART_VERSION"
+	format="tgz"
+	chart_archive_filename="${!repo}\/${!name}-${!version}.$format"
+	v4m_replace "__${prefix}_CHART_REPO__" "${!repo}" "$file"
+	v4m_replace "__${prefix}_CHART_NAME__" "${!name}" "$file"
+	v4m_replace "__${prefix}_CHART_VERSION__" "${!version}" "$file"
+	v4m_replace "__${prefix}_CHART_ARCHIVE__" "$chart_archive_filename" "$file"
 
 }
 
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -w filename


Copy link
Contributor

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck -e SC1004' returned error 1 finding the following syntactical issues:

----------

In .github/workflows/build-artifact/generate_inventory.sh line 12:
CHECK_HELM=false
^--------^ SC2034 (warning): CHECK_HELM appears unused. Verify use (or export if used externally).


In .github/workflows/build-artifact/generate_inventory.sh line 13:
CHECK_KUBERNETES=false
^--------------^ SC2034 (warning): CHECK_KUBERNETES appears unused. Verify use (or export if used externally).


In .github/workflows/build-artifact/generate_inventory.sh line 15:
source bin/common.sh
       ^-----------^ SC1091 (info): Not following: bin/common.sh was not specified as input (see shellcheck -x).

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- CHECK_HELM appears unused. Verify...
  https://www.shellcheck.net/wiki/SC1091 -- Not following: bin/common.sh was ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors

'shfmt -s' returned error 1 finding the following formatting issues:

----------
--- .github/workflows/build-artifact/generate_inventory.sh.orig
+++ .github/workflows/build-artifact/generate_inventory.sh
@@ -21,18 +21,18 @@
 
 function buildHelmArchiveFilename {
 
-   local prefix repo name version format chart_archive_filename
+	local prefix repo name version format chart_archive_filename
 
-   prefix=$1
-   repo="${prefix}_CHART_REPO"
-   name="${prefix}_CHART_NAME"
-   version="${prefix}_CHART_VERSION"
-   format="tgz"
-   chart_archive_filename="${!repo}\/${!name}-${!version}.$format"
-   v4m_replace "__${prefix}_CHART_REPO__" "${!repo}" "$file"
-   v4m_replace "__${prefix}_CHART_NAME__" "${!name}" "$file"
-   v4m_replace "__${prefix}_CHART_VERSION__" "${!version}" "$file"
-   v4m_replace "__${prefix}_CHART_ARCHIVE__" "$chart_archive_filename" "$file"
+	prefix=$1
+	repo="${prefix}_CHART_REPO"
+	name="${prefix}_CHART_NAME"
+	version="${prefix}_CHART_VERSION"
+	format="tgz"
+	chart_archive_filename="${!repo}\/${!name}-${!version}.$format"
+	v4m_replace "__${prefix}_CHART_REPO__" "${!repo}" "$file"
+	v4m_replace "__${prefix}_CHART_NAME__" "${!name}" "$file"
+	v4m_replace "__${prefix}_CHART_VERSION__" "${!version}" "$file"
+	v4m_replace "__${prefix}_CHART_ARCHIVE__" "$chart_archive_filename" "$file"
 
 }
 
----------

You can reformat the above files to meet shfmt's requirements by typing:

  shfmt -s -w filename


@ceelias ceelias merged commit 4834c64 into main May 14, 2024
1 check failed
@ceelias ceelias deleted the add-inventory-action branch May 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant